From 4f0e948a84d815f42fa06000a0d71d7aa07c32b9 Mon Sep 17 00:00:00 2001 From: SileNce5k Date: Tue, 24 Jun 2025 02:47:01 +0200 Subject: [PATCH 1/3] Remove getGuildCount test This function has been renamed and stuff so I have to rethink how I'll implement tests for it. --- tests/getGuildCount.test.js | 17 ----------------- 1 file changed, 17 deletions(-) delete mode 100644 tests/getGuildCount.test.js diff --git a/tests/getGuildCount.test.js b/tests/getGuildCount.test.js deleted file mode 100644 index cc86368..0000000 --- a/tests/getGuildCount.test.js +++ /dev/null @@ -1,17 +0,0 @@ -const getGuildInfo = require('../util/getGuildInfo'); - - - -test("Testing getGuildCount", () => { - for(let i = 1; i < 200000; i = i+i*30 ){ - let client = {guilds: {cache: new Map()}} - client.guilds.cache.each = client.guilds.cache.forEach; - - for(let j = 0; j < i; j++){ - client.guilds.cache.set(`num: ${j}`, j); - } - - expect(getGuildInfo(client).guildCount).toBe(i); - - } -}) \ No newline at end of file From 28cc7d6f15e29a0516db0078ee21e2a889029da8 Mon Sep 17 00:00:00 2001 From: SileNce5k Date: Tue, 24 Jun 2025 02:48:10 +0200 Subject: [PATCH 2/3] Use const --- util/getGuildInfo.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/getGuildInfo.js b/util/getGuildInfo.js index 30b80fe..f1043fa 100644 --- a/util/getGuildInfo.js +++ b/util/getGuildInfo.js @@ -1,7 +1,7 @@ module.exports = function(client){ let guildCount = 0; let totalMembers = 0; - let uniqueMembers = new Map(); + const uniqueMembers = new Map(); client.guilds.cache.each(guild => { guildCount++ totalMembers += guild.memberCount; @@ -11,6 +11,6 @@ module.exports = function(client){ } }) }); - let uniqueMemberCount = uniqueMembers.size; + const uniqueMemberCount = uniqueMembers.size; return {guildCount, totalMembers, uniqueMemberCount}; } \ No newline at end of file From b9e0b6abd3f185aa7fafc7b9865cf4c269b0bc46 Mon Sep 17 00:00:00 2001 From: SileNce5k Date: Tue, 24 Jun 2025 02:49:52 +0200 Subject: [PATCH 3/3] Use has instead of get --- util/getGuildInfo.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/getGuildInfo.js b/util/getGuildInfo.js index f1043fa..5d1b74e 100644 --- a/util/getGuildInfo.js +++ b/util/getGuildInfo.js @@ -6,7 +6,7 @@ module.exports = function(client){ guildCount++ totalMembers += guild.memberCount; guild.members.cache.each(member => { - if(!uniqueMembers.get(member.id)){ + if(!uniqueMembers.has(member.id)){ uniqueMembers.set(member.id, true); } })